Add support for readonly classes
#147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IonBazan
force-pushed
the
feature/readonly-class
branch
from
f4e843b to
f8b0360
Compare
IonBazan
force-pushed
the
feature/readonly-class
branch
from
f8b0360 to
0f49852
Compare
|
Hello @Ocramius, I have went through PR and found this PR is supporting PHP8.2, Hence My PR will not be required #151 |
|
@IonBazan could you rebase on 4.8.x ? |
Closed
IonBazan
force-pushed
the
feature/readonly-class
branch
from
0f49852 to
29c93c0
Compare
IonBazan
commented
Nov 20, 2022
Signed-off-by: Ion Bazan <[email protected]>
Ocramius
force-pushed
the
feature/readonly-class
branch
from
1231f15 to
76aa40b
Compare
Ocramius
approved these changes
Nov 21, 2022
This new test limits itself to verifying the semantics around `final` class creation, and it isn't really a problem to rely on the deprecated API in here (for now). Signed-off-by: Marco Pivetta <[email protected]>
Ocramius
changed the title
readonly classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds support for
readonlyclasses generation (PHP 8.2 and up).It also adds support for
finalclasses generation fromClassReflection(not sure why it was skipped earlier).Added PHP 8.2 to the build matrix and
composer.json- tests are passing.See: #142