You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Return type hints for implementations of \Iterator::current() is incomplete due to inconsistent usage. Right now, type hints are only documented in method comment. Either leave it or a change is required to match return types.
ExtractionInterface::extract() expects parameter be of type object. From my understanding HydratingResultSet::toArray() could give provide any of null|array|bool. Not sure if I misunderstand it or if that needs some attention.
This PR provides changes described in #364
I have two questions from refactoring.
\Iterator::current()
is incomplete due to inconsistent usage. Right now, type hints are only documented in method comment. Either leave it or a change is required to match return types.Iterator::current()
documents a mixed (any) typeAbstractResultSet::current()
documentsarray|null
ResultSet::current()
documentsarray|ArrayObject|null
HydratingResultSet::current()
documentsnull|array|bool
ExtractionInterface::extract()
expects parameter be of type object. From my understandingHydratingResultSet::toArray()
could give provide any ofnull|array|bool
. Not sure if I misunderstand it or if that needs some attention.Originally posted by @arueckauer at zendframework/zend-db#370
The text was updated successfully, but these errors were encountered: