Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor of Zend\Db\ResultSet for 3.0.0 #12

Closed
weierophinney opened this issue Dec 31, 2019 · 1 comment
Closed

Refactor of Zend\Db\ResultSet for 3.0.0 #12

weierophinney opened this issue Dec 31, 2019 · 1 comment

Comments

@weierophinney
Copy link
Member

This PR provides changes described in #364

I have two questions from refactoring.

  1. Return type hints for implementations of \Iterator::current() is incomplete due to inconsistent usage. Right now, type hints are only documented in method comment. Either leave it or a change is required to match return types.
  • Iterator::current() documents a mixed (any) type
  • AbstractResultSet::current() documents array|null
  • ResultSet::current() documents array|ArrayObject|null
  • HydratingResultSet::current() documents null|array|bool
  1. ExtractionInterface::extract() expects parameter be of type object. From my understanding HydratingResultSet::toArray() could give provide any of null|array|bool. Not sure if I misunderstand it or if that needs some attention.

Originally posted by @arueckauer at zendframework/zend-db#370

@weierophinney
Copy link
Member Author

This package is considered feature-complete, and is now in security-only maintenance mode, following a decision by the Technical Steering Committee.
If you have a security issue, please follow our security reporting guidelines.
If you wish to take on the role of maintainer, please nominate yourself

If you are looking for an actively maintained package alternative, we recommend:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant