This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides changes described in #364
I have two questions from refactoring.
\Iterator::current()
is incomplete due to inconsistent usage. Right now, type hints are only documented in method comment. Either leave it or a change is required to match return types.Iterator::current()
documents a mixed (any) typeAbstractResultSet::current()
documentsarray|null
ResultSet::current()
documentsarray|ArrayObject|null
HydratingResultSet::current()
documentsnull|array|bool
ExtractionInterface::extract()
expects parameter be of type object. From my understandingHydratingResultSet::toArray()
could give provide any ofnull|array|bool
. Not sure if I misunderstand it or if that needs some attention.