-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove FilterProviderInterface
#205
Merged
gsteel
merged 3 commits into
laminas:3.0.x
from
gsteel:v3/remove-filter-provider-interface
Jan 6, 2025
Merged
Remove FilterProviderInterface
#205
gsteel
merged 3 commits into
laminas:3.0.x
from
gsteel:v3/remove-filter-provider-interface
Jan 6, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation must also be removed: laminas-filter/docs/book/v3/application-integration/providing-filters-via-modules.md Lines 1 to 16 in 08e0bb9
|
gsteel
force-pushed
the
v3/remove-filter-provider-interface
branch
from
December 4, 2024 22:49
fe142b9
to
abff8c3
Compare
I've retained and updated the docs to point to the same interface in the Module Manager lib/docs |
froschdesign
reviewed
Dec 5, 2024
froschdesign
approved these changes
Jan 6, 2025
This interface is MVC Module Manager specific and does not belong in this library Signed-off-by: George Steel <[email protected]>
Signed-off-by: George Steel <[email protected]>
Signed-off-by: George Steel <[email protected]>
gsteel
force-pushed
the
v3/remove-filter-provider-interface
branch
from
January 6, 2025 20:21
3ebe510
to
a5fd879
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This interface is MVC Module Manager specific and does not belong in this library
See #204