Refactor htmlentities filter #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsteel
requested changes
Jan 6, 2025
There was a problem hiding this comment.
Thanks @marcelthole - Sorry it's taken a while to get a review
This was referenced Jan 6, 2025
|
2.40.0 has been released so a rebase will be required |
marcelthole
force-pushed
the
refactor-htmlentities-filter
branch
from
9fb3ad2 to
cf44f2c
Compare
gsteel
requested changes
Jan 7, 2025
There was a problem hiding this comment.
Thanks @marcelthole - A couple of minor adjustments and this is good to go 👍
Signed-off-by: Marcel Thole <[email protected]>
…dd missing testcases for doublequote Signed-off-by: Marcel Thole <[email protected]>
marcelthole
force-pushed
the
refactor-htmlentities-filter
branch
from
cf44f2c to
a4dbbcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move HtmlEntities filter also to the implementation via FilterInterface and removed the AbstractFilter