Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.3 support #46

Closed
GuySartorelli opened this issue Nov 23, 2023 · 6 comments · Fixed by #47
Closed

PHP 8.3 support #46

GuySartorelli opened this issue Nov 23, 2023 · 6 comments · Fixed by #47

Comments

@GuySartorelli
Copy link
Contributor

GuySartorelli commented Nov 23, 2023

Feature Request

Q A
New Feature no
RFC no
BC Break no

Summary

The PHP dependency constraint is very strict, and doesn't allow new versions of PHP to be used as they come out:
"php": "~8.0.0 || ~8.1.0 || ~8.2.0",

Please either loosen this constraint so that people can use newer versions of PHP as they come out (e.g. ^8.0.0), or else add official support for PHP 8.3 now that it has been released.

@froschdesign
Copy link
Member

@GuySartorelli

Please either loosen this constraint so that people can use newer versions of PHP as they come out (e.g. ^8.0.0), or else

Unfortunately, PHP does not follow semantic versioning and brings backward compatibility breaks with every minor version:

…add official support for PHP 8.3 now that it has been released.

Create a pull request to allow version 8.3 and we will be happy to review it.
Thanks in advance! 👍🏻

@GuySartorelli
Copy link
Contributor Author

I've raised #47

Personally I don't think PHP does introduce breaking changes in minor releases, other than new deprecation warnings which aren't breaking changes for this library I wouldn't expect... but even if it does, I'd argue that you're more likely to have those problems fixed quickly if you let people install with the new version of PHP and therefore find those broken things. In the meantime, they can avoid the bugs by just not upgrading their PHP version (which is effectively the current approach anyway).

That said, I'm not here to argue or to change your processes, so I've just added ~8.3.0 into the dependency constraint.

@Ocramius
Copy link
Member

Personally I don't think PHP does introduce breaking changes in minor releases

As a long-term OSS maintainer, this is not true :-)

Anyway, expanding the constraint once a version can be tested is the right way to do this.

You can read more on this topic at laminas/laminas-diactoros#117 (comment), where I detailed exactly why you can't and shouldn't use ^8.0, and never-ever >=8.0 :-)

@GuySartorelli
Copy link
Contributor Author

Fair enough, like I say I don't agree but I'm not here to change your processes. I don't subscribe to the idea that there is an objective right way for this constraint, but I accept that this is the way the maintainers have decided is right for this project.

@Ocramius
Copy link
Member

It may not be the right way for you, but it's objectively the SemVer way.

@GuySartorelli
Copy link
Contributor Author

GuySartorelli commented Nov 25, 2023

I'm going to close this issue now. The conversation has gone off topic and there's a PR open to implement the support this issue was intended to encourage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants