-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PHP 8.3 support #47
Conversation
php 8.0 reached eol. Please also drop it and update platform to 8.1 |
.......... Okay. That's not at all in the scope of what I'm doing this change for, but if that's what has to be done for you to add PHP 8.3 support, I'll do it. |
Signed-off-by: Guy Sartorelli <[email protected]>
65a91ad
to
38d9c59
Compare
Done |
Looks like there are some PHP 8.1 failures in CI - those are out of scope for this PR. |
Those errors appear to be more than just from updates to static analysis tool. They would need to be addressed first before this PR can be merged. |
Signed-off-by: Aleksei Khudiakov <[email protected]>
Signed-off-by: Aleksei Khudiakov <[email protected]>
Signed-off-by: Aleksei Khudiakov <[email protected]>
39252a8
to
c8d6d19
Compare
I do not understand why code sniffer invokes fatal error requiring return type will change annotation but it does not fail locally on php 8.2 or via tests |
Hm. That is a LOT of skipped tests |
Signed-off-by: Aleksei Khudiakov <[email protected]>
c8d6d19
to
99887d7
Compare
generic ldap resource changed to dedicated objects starting with php 8.1. Since php 8.1 is now minimum the resource type is no longer valid so phpdoc was updated to reflect that and checks for resource were simplified to look only for relevant classes. Missing |
Description
PHP 8.3 can't be used with this library due to the strict dependency constraint.
Loosening the constraint to allow new versions of PHP 8 to be automatically installable isn't allowed as per #46 (comment), so I'm just adding PHP 8.3 support here.
I've checked against the changes listed in https://php.watch/versions/8.3 and none of the listed changes should break anything this library uses.
Hopefully your CI will automagically pick up that it needs to test against PHP 8.3 - but if not, please let me know what I need to change and I'll change it.
Closes #46