Added support for PHP 8.1 #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Following the discussion in #46 , I rebased on top of #45 . |
|
The rebase seems not applied, you may need to cherry-pick your commit to differrent branch, reset --hard, re-fetch latest 2.0.x branch, and create branch based of it, the cherry-pick your patch commit to it, then re-create pull request |
|
To merge this PR, #45 should be merged first. Alternatively, it can be merged to 1.3.x or 1.4.x (if branched of 1.3.x). |
Signed-off-by: Koen1999 <[email protected]>
Signed-off-by: Aleksei Khudiakov <[email protected]>
|
@Koen1999 thank you I rebased your branch to resolve conflict and dropped PHP 7.3 at the same time, which we no longer support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for PHP 8.1 and thus fixes #47 .
It is not done yet. We need to decide on a way to deal with the potential cache adapters.