Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecated messages #32

Merged
merged 9 commits into from
Mar 16, 2023
Merged

Fix deprecated messages #32

merged 9 commits into from
Mar 16, 2023

Conversation

kewlburn
Copy link
Contributor

  • fixed deprecated Paginator component.
  • upgraded fixture to new cakephp fixture system.
  • fixed deprecated phpunit expectErrorMessageMatches() and expectError() methods.
  • fixed deprecated Time (I18n) class.

@chitoku-k
Copy link
Member

@kewlburn
Thank you for raising this! Could you rebase on top of the master branch so your changes will trigger testing? I had configured the CI in the wrong way, which has now been fixed on master.

Most changes look good; however, I found some files are not terminated by a line break. Could you fix them?

@kewlburn
* fixed deprecated Paginator component.
c4ec82f 
* upgraded fixture to new cakephp fixture system.
* fixed deprecated phpunit expectErrorMessageMatches() and expectError() methods.
* fixed deprecated Time (I18n) class.
@kewlburn kewlburn force-pushed the deprecated-messages branch from 6f6d43c to c4ec82f Compare March 16, 2023 05:27
chitoku-k
chitoku-k requested changes Mar 16, 2023
View reviewed changes
Copy link
Member

@chitoku-k chitoku-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now deprecation messages are all gone! Please fix issues in lifecycle callbacks and some cosmetic preferences before I merge this.

.gitignore Outdated Show resolved Hide resolved
phpunit.xml.dist Outdated Show resolved Hide resolved
tests/TestCase/PaginationResultTest.php Outdated Show resolved Hide resolved
tests/bootstrap.php Outdated Show resolved Hide resolved
tests/schema.php Outdated Show resolved Hide resolved
tests/TestCase/PaginationResultTest.php Show resolved Hide resolved
tests/TestCase/PaginationResultTest.php Show resolved Hide resolved
tests/schema.php Show resolved Hide resolved
@kewlburn
Copy link
Contributor Author

@chitoku-k thank you again.

chitoku-k
chitoku-k approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@chitoku-k chitoku-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the contribution 👍

@chitoku-k chitoku-k merged commit 804eff7 into lampager:master Mar 16, 2023
This was referenced Mar 16, 2023
Merged
Merged
Merged
Merged
@kewlburn kewlburn deleted the deprecated-messages branch March 17, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chitoku-k chitoku-k chitoku-k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kewlburn @chitoku-k