Turn some calls to underlying into superType.
#15455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwijnand
reviewed
Jun 15, 2022
dwijnand
reviewed
Jun 16, 2022
| @@ -5,20 +5,20 @@ scala> object Foo2 { type T[+A] = [B] =>> (A, B) } | |||
| scala> object Foo3 { type T[+A] = [B] =>> [C] =>> (A, B) } | |||
| // defined object Foo3 | |||
| scala> ((1, 2): Foo1.T[Int]): Foo1.T[Any] | |||
| val res0: (Any, Int) = (1,2) | |||
| val res0: Foo1.T[Any] = (1,2) | |||
|
To fix the MiMa tests, we should be able to re-run the tests after #15457 is merged (no-rebase needed). |
The fixed frontend dealiases less in the inferred types of i6474, which is a good thing.
|
test performance please |
|
performance test scheduled: 1 job(s) in queue, 0 running. |
|
Performance test finished successfully: Visit https://dotty-bench.epfl.ch/15455/ to see the changes. Benchmarks is based on merging with main (f58c158) |
|
test performance please |
|
performance test scheduled: 1 job(s) in queue, 0 running. |
|
Performance test finished successfully: Visit https://dotty-bench.epfl.ch/15455/ to see the changes. Benchmarks is based on merging with main (4cb967f) |
mbovel
approved these changes
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #15453