Fix MiMa filters for base version 3.2.1-RC1 #15457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
changed the title
|
We might still have a failure on Fix in #15458. |
|
Sorry about the inherited scope bug. I haven't gotten to fixing that yet. |
This was referenced Jun 16, 2022
nicolasstucki
force-pushed
the
fix-mima-filters
branch
from
89b123f to
89eb46d
Compare
MiMa seems to check if the definition is experimental but it is missing the check if the owner is experimental.
This issue was introduced in scala#15454. This PR should have added these filter but did not. It also failed the MiMa tests as expected but was accidentally merged.
nicolasstucki
force-pushed
the
fix-mima-filters
branch
from
89eb46d to
04a5d51
Compare
mbovel
approved these changes
Jun 16, 2022
|
It seems that only Could someone double-check the test output and merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was introduced in #15454. This PR should have added these filters but did not. It also failed the MiMa tests as expected but was accidentally merged.