Skip to content

Commit

Permalink
fix window test and sleep longer on asof test (#1204)
Browse files Browse the repository at this point in the history
  • Loading branch information
chebbyChefNEQ authored and rmeng committed Sep 4, 2023
1 parent 14807bc commit 546eb97
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
8 changes: 5 additions & 3 deletions python/python/tests/test_dataset.py
Original file line number Diff line number Diff line change
Expand Up @@ -157,17 +157,19 @@ def test_asof_checkout(tmp_path: Path):

lance.write_dataset(table, base_dir)
assert len(lance.dataset(base_dir).versions()) == 1
time.sleep(0.01)
time.sleep(0.1)
ts_1 = datetime.now()
time.sleep(0.01)
time.sleep(0.1)

lance.write_dataset(table, base_dir, mode="append")
assert len(lance.dataset(base_dir).versions()) == 2
time.sleep(0.1)
ts_2 = datetime.now()
time.sleep(0.01)
time.sleep(0.1)

lance.write_dataset(table, base_dir, mode="append")
assert len(lance.dataset(base_dir).versions()) == 3
time.sleep(0.1)
ts_3 = datetime.now()

# check that only the first batch is present
Expand Down
1 change: 1 addition & 0 deletions rust/src/io/commit/external_manifest.rs
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,7 @@ mod test {
assert_eq!(ds.count_rows().await.unwrap(), 100);
}

#[cfg(not(windows))]
#[tokio::test]
async fn test_concurrent_commits_are_okay() {
let sleepy_store = SleepyExternalManifestStore::new();
Expand Down

0 comments on commit 546eb97

Please sign in to comment.