Sorting dataset versions (#668)

* Sorting dataset versions * fixed test
lancedb · Mar 8, 2023 · 70560f6 · 70560f6
1 parent 72701a6
commit 70560f6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/python/python/tests/test_dataset.py b/python/python/tests/test_dataset.py
@@ -52,7 +52,7 @@ def test_versions(tmp_path: Path):
 
     assert len(lance.dataset(base_dir).versions()) == 2
 
-    v2, v1 = lance.dataset(base_dir).versions()
+    v1, v2 = lance.dataset(base_dir).versions()
     assert v1["version"] == 1
     assert v2["version"] == 2
     assert isinstance(v1["timestamp"], datetime)

diff --git a/rust/src/dataset.rs b/rust/src/dataset.rs
@@ -570,6 +570,7 @@ impl Dataset {
             let manifest = read_manifest(&self.object_store, path).await?;
             versions.push(Version::from(&manifest));
         }
+        versions.sort_by_key(|v| v.version);
         Ok(versions)
     }