typecheck arrow objects before sending to Rust

lancedb · May 30, 2023 · fa659ef · fa659ef
1 parent 5aff44e
commit fa659ef
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/python/python/lance/dataset.py b/python/python/lance/dataset.py
@@ -531,6 +531,8 @@ def _commit(
         """
         if isinstance(base_uri, Path):
             base_uri = str(base_uri)
+        if not isinstance(new_schema, pa.Schema):
+            raise TypeError(f"schema must be pyarrow.Schema, got {type(new_schema)}"
         _Dataset.commit(base_uri, new_schema, fragments)
         return LanceDataset(base_uri)
 

diff --git a/python/python/lance/fragment.py b/python/python/lance/fragment.py
@@ -169,7 +169,7 @@ def add_columns(
         return updater.finish()
 
     @property
-    def schema(self):
+    def schema(self) -> pa.Schema:
         """Return the schema of this fragment."""
 
         return self._fragment.schema()