Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roundtrip schema metadata #1128

Closed
wjones127 opened this issue Aug 9, 2023 · 0 comments · Fixed by #1133
Closed

Roundtrip schema metadata #1128

wjones127 opened this issue Aug 9, 2023 · 0 comments · Fixed by #1133
Assignees
@gsilvestrin
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@wjones127
Copy link
Contributor

We have a field for schema metadata in the manifest, but we don't deserialize it from the protobuf message in Lance.
@wjones127 wjones127 added bug Something isn't working good first issue Good for newcomers labels Aug 9, 2023
@gsilvestrin gsilvestrin self-assigned this Aug 10, 2023
gsilvestrin pushed a commit that referenced this issue Aug 11, 2023
feat: Persist schema metadata
41642d8 
Close #1128
@gsilvestrin gsilvestrin mentioned this issue Aug 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gsilvestrin gsilvestrin

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Persist schema metadata lancedb/lance
2 participants
@gsilvestrin @wjones127