Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Field metadata is not available on JSON arrow schema #3378

Closed
albertlockett opened this issue Jan 14, 2025 · 0 comments · Fixed by #3379
Closed

Field metadata is not available on JSON arrow schema #3378

albertlockett opened this issue Jan 14, 2025 · 0 comments · Fixed by #3379
Assignees
@albertlockett
Labels
bug Something isn't working rust Rust related tasks

Comments

@albertlockett
Copy link
Contributor

When the dataset schema has field metadata and we serialize/deserialize it as a JSON schema, we lose the field metadata.
https://github.com/lancedb/lance/blob/main/rust/lance/src/arrow/json.rs
@albertlockett albertlockett added bug Something isn't working rust Rust related tasks labels Jan 14, 2025
@albertlockett albertlockett self-assigned this Jan 14, 2025
@albertlockett albertlockett mentioned this issue Jan 14, 2025
Merged
albertlockett added a commit that referenced this issue Jan 14, 2025
@albertlockett @westonpace
fix: json schema serializes field metadata (#3379)
4d77d7b 
fixes: #3378

---------

Co-authored-by: Weston Pace <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@albertlockett albertlockett

Labels
bug Something isn't working rust Rust related tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: json schema serializes field metadata lancedb/lance
1 participant
@albertlockett