Basic python extension types for image, point2d, and box2d #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changhiskhan
force-pushed
the
changhiskhan/extension-types
branch
2 times, most recently
from
c55e7cb to
cf82098
Compare
changhiskhan
force-pushed
the
changhiskhan/extension-types
branch
from
cf82098 to
98e9a35
Compare
eddyxu
reviewed
Aug 24, 2022
python/lance/tests/test_types.py
Outdated
| from lance.types import * | ||
|
|
||
|
|
||
| @pytest.mark.skipif( |
There was a problem hiding this comment.
we can skip the entire file
| @@ -0,0 +1,56 @@ | |||
| import platform | |||
python/lance/types.py
Outdated
| __all__ = ["ImageType", "ImageUriType", "ImageBinaryType", "Point2dType", "Box2dType"] | ||
|
|
||
|
|
||
| # Arrow extension type |
There was a problem hiding this comment.
move imports above __all__ = [...] ?
Seems need to run isort as well.
| import pyarrow as pa | ||
|
|
||
|
|
||
| __all__ = ["ImageType", "ImageUriType", "ImageBinaryType", "Point2dType", "Box2dType"] |
There was a problem hiding this comment.
Should we not expose ImageType, which is the base class?
There was a problem hiding this comment.
ImageType.from_storage allows the user to get the correct subtype directly from storage array so they don't need to think about whether they need a uri or binary type
| pass | ||
|
|
||
| def __arrow_ext_serialize__(self): | ||
| return b"" |
There was a problem hiding this comment.
Curious what does this function do?
There was a problem hiding this comment.
For parametrized types this returns extra information (from the examples in Arrow docs)
eddyxu
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on #100 . The unit tests were segfaulting until I rebuilt liblance using #100 branch.