Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix length calculation when reading list array with offset #104

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

eddyxu
Copy link
Contributor

@eddyxu eddyxu commented Aug 15, 2022

Closes #96

@eddyxu
Copy link
Contributor Author

eddyxu commented Aug 15, 2022

Verified with

import lance
import pyarrow.compute as pc

ids = [391895, 522418, 184613, 318219, 554625, 574769, 60623, 309022, 5802, 222564]
ds = lance.dataset('s3://eto-public/datasets/coco/coco_links.lance')
tbl = ds.to_table(filter=pc.field('image_id').isin(ids))
print(tbl)

@eddyxu eddyxu requested a review from changhiskhan August 15, 2022 04:27
@eddyxu eddyxu self-assigned this Aug 15, 2022
@eddyxu eddyxu added bug Something isn't working c++ C++ issues arrow Apache Arrow related issues labels Aug 15, 2022
@eddyxu eddyxu merged commit 58576ee into main Aug 15, 2022
@eddyxu eddyxu deleted the lei/read_list_array_with_indices branch August 15, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Apache Arrow related issues bug Something isn't working c++ C++ issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lance filtering not working
2 participants