Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't compare metadata when checking schema in append #1051

Merged
merged 1 commit into from
Jul 10, 2023
Merged

fix: don't compare metadata when checking schema in append #1051

merged 1 commit into from
Jul 10, 2023

Conversation

wjones127
Copy link
Contributor

Fixes #1048

@wjones127 wjones127 requested a review from eddyxu July 10, 2023 18:48
eddyxu
eddyxu approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@eddyxu eddyxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnsco
Copy link
Contributor

dnsco commented Jul 10, 2023

Thanks <3

@wjones127 wjones127 merged commit 8c3d615 into main Jul 10, 2023
@wjones127 wjones127 deleted the wjones127/schema-equality-metadata branch July 10, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyxu eddyxu eddyxu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot append with different schema metadata
3 participants
@wjones127 @dnsco @eddyxu