docs: add clarifications to format about fields #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjones127
commented
Jul 10, 2023
protos/format.proto
Outdated
Comment on lines
144
to
145
| // This must be equal in length to the number of columns in the file. The order | ||
| // of the ids determines the mapping from field id to column position. |
There was a problem hiding this comment.
Yes, that's right. So if you already change the format.proto, let's keep a "already assigned max field id" in the manifest? To prevent re-use existing field id if deleted.
There was a problem hiding this comment.
I will do this in a follow-up. #1090
wjones127
changed the title
wjones127
force-pushed
the
wjones127/format-docs-more
branch
from
da0166d to
f990ec3
Compare
wjones127
force-pushed
the
wjones127/format-docs-more
branch
from
4db96ce to
4484ff0
Compare
eddyxu
approved these changes
Jul 24, 2023
eddyxu
pushed a commit
that referenced
this pull request
Jul 25, 2023
* docs: add clarifications to format * docs: add fragment diagram * docs: clarify field ids are positional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fills out more details in the existing format.