Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug in pandas check #1085

Merged
merged 1 commit into from
Jul 23, 2023
Merged

fix bug in pandas check #1085

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/benchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
name: Run benchmarks

on:
push:
branches: ["main"]
workflow_dispatch:

jobs:
dataset:
Expand All @@ -26,7 +25,8 @@ jobs:
- name: Pip install
working-directory: python
run: |
python -m pip install $(ls target/wheels/*.whl)
pip install $(ls target/wheels/*.whl)
pip install pandas
- name: Run test
working-directory: benchmarks/${{ matrix.dataset }}
run: |
Expand Down
4 changes: 2 additions & 2 deletions python/python/lance/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@
try:
import pandas as pd

ts_types = Union[datetime, str]
ts_types = Union[datetime, pd.Timestamp, str]
except ImportError:
pd = None
ts_types = Union[datetime, pd.Timestamp, str]
ts_types = Union[datetime, str]


def sanitize_ts(ts: ts_types) -> datetime:
Expand Down