[WIP] Tf.data pipeline #1087
Merged
[WIP] Tf.data pipeline #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyxu
force-pushed
the
lei/tf_data
branch
2 times, most recently
from
2060acb to
37649cf
Compare
eddyxu
added
Tensorflow
eddyxu
requested review from
wjones127,
changhiskhan,
chebbyChefNEQ and
AyushExel
wjones127
reviewed
Jul 25, 2023
wjones127
reviewed
Jul 26, 2023
| if isinstance(tensor_spec, tf.RaggedTensorSpec): | ||
| return tf.ragged.constant(column, dtype=tensor_spec.dtype) | ||
| else: | ||
| return tf.constant(column, dtype=tensor_spec.dtype) |
There was a problem hiding this comment.
Are there any docs on how this works? We can just pass arrow arrays into tf.constant and tensorflow understands arrow? Or is there some other protocol here?
There was a problem hiding this comment.
https://www.tensorflow.org/tutorials/customization/basics#numpy_compatibility it is not yet clear to me that this is a zero copy operation yet.
Let's digg more in implementation details as follow up? Wanted to get the API spec out for now.
wjones127
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.