Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python] Set batch_size in Dataset::scanner() #1088

Merged
merged 6 commits into from
Jul 24, 2023
Merged

[Python] Set batch_size in Dataset::scanner() #1088

merged 6 commits into from
Jul 24, 2023

Conversation

eddyxu
Copy link
Contributor

@eddyxu eddyxu commented Jul 24, 2023

To allow scanner to customize batch_size.

@wjones127
Copy link
Contributor

FYI I'm making the same change here: #1082

I can rebase after we merge this if you want this separate.

@eddyxu eddyxu marked this pull request as ready for review July 24, 2023 18:00
@eddyxu eddyxu requested a review from wjones127 July 24, 2023 18:00
@eddyxu eddyxu self-assigned this Jul 24, 2023
@eddyxu eddyxu added python arrow Apache Arrow related issues labels Jul 24, 2023
@eddyxu eddyxu merged commit 656ace2 into main Jul 24, 2023
@eddyxu eddyxu deleted the lei/scanner_batch branch July 24, 2023 18:26
@eddyxu eddyxu mentioned this pull request Jul 24, 2023
Closed
wjones127 pushed a commit that referenced this pull request Jul 24, 2023
@eddyxu @wjones127
[Python] Set batch_size in Dataset::scanner() (#1088)
971a9ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjones127 wjones127 wjones127 approved these changes

Assignees

@eddyxu eddyxu

Labels
arrow Apache Arrow related issues python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eddyxu @wjones127