[Rust] Benchmark for dot product #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eddyxu
commented
Aug 17, 2023
•
eddyxu
commented
- Add benchmark for dot product of f16/f32/f64
- Simd for f32 dot.
eddyxu
changed the title
| const TOTAL: usize = 1024 * 1024; // 1M vectors | ||
|
|
||
| run_bench::<Float16Type>(c); | ||
| c.bench_function("Dot(f16, SIMD)", |b| { |
There was a problem hiding this comment.
why not put this in run_bench as well?
There was a problem hiding this comment.
This is due to the generic specialization thing. Could not make generic trait working
| @@ -53,6 +55,13 @@ impl Dot for [f32] { | |||
| type Output = f32; | |||
|
|
|||
| fn dot(&self, other: &[f32]) -> f32 { | |||
| #[cfg(target_arch = "x86_64")] | |||
| { | |||
| if is_x86_feature_detected!("fma") { | |||
There was a problem hiding this comment.
do we need AVX2 flag here too?
There was a problem hiding this comment.
We dont not need. fma is one set newer than to avx2 , for the machine with fma, all of them have avx2.
chebbyChefNEQ
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.