Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes for benchmarks #115

Merged
merged 1 commit into from
Aug 16, 2022
Merged

Minor fixes for benchmarks #115

merged 1 commit into from
Aug 16, 2022

Conversation

changhiskhan
Copy link
Contributor

  1. Lance cannot write boolean array just yet so iscrowd stays int
  2. Add kwargs to DatasetConverter.make_embedded_dataset to control parquet row_group_size
  3. blacken

@changhiskhan
Minor fixes for benchmarks
61590bd 
1. Lance cannot write boolean array just yet so iscrowd stays int
2. Add kwargs to DatasetConverter.make_embedded_dataset to control parquet row_group_size
3. blacken
@changhiskhan changhiskhan requested a review from eddyxu August 16, 2022 21:15
eddyxu
eddyxu approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@eddyxu eddyxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks simple. LGTM

@changhiskhan changhiskhan merged commit beb1d92 into main Aug 16, 2022
@changhiskhan changhiskhan deleted the changhiskhan/fix-bmark branch August 16, 2022 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyxu eddyxu eddyxu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@changhiskhan @eddyxu