Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose aws region configurability #1153

Merged
merged 1 commit into from
Aug 22, 2023
Merged

expose aws region configurability #1153

merged 1 commit into from
Aug 22, 2023

Conversation

chebbyChefNEQ
Copy link
Contributor

@chebbyChefNEQ chebbyChefNEQ commented Aug 21, 2023 •
edited
Loading

previously we could only set aws region via env var and IMDS, this PR opens up configuration during construction

@chebbyChefNEQ chebbyChefNEQ marked this pull request as ready for review August 21, 2023 22:53
@chebbyChefNEQ chebbyChefNEQ mentioned this pull request Aug 21, 2023
Closed
@chebbyChefNEQ
Copy link
Contributor Author

going to land this only arm builds seems to be stuck

@chebbyChefNEQ chebbyChefNEQ merged commit 1ad6d99 into main Aug 22, 2023
@chebbyChefNEQ chebbyChefNEQ deleted the rmeng/aws-region branch August 22, 2023 03:04
@chebbyChefNEQ chebbyChefNEQ restored the rmeng/aws-region branch August 22, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjones127 wjones127 wjones127 approved these changes

@eddyxu eddyxu Awaiting requested review from eddyxu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chebbyChefNEQ @wjones127