Project skips scan if the filter covers all the columns #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyxu
added
bug
changhiskhan
approved these changes
Aug 18, 2022
| assert(values->num_rows() == batch->num_rows()); | ||
| ARROW_ASSIGN_OR_RAISE(auto merged, lance::arrow::MergeRecordBatches(values, batch)); | ||
| return merged; | ||
| if (scan_schema_->fields().empty()) { |
There was a problem hiding this comment.
What happens if user passes in lance.scanner(ds, columns=[])? Will they get an empty table back or will an exception be raised?
There was a problem hiding this comment.
we have not had the check, but I feel that it should not be a silent error, so it should raise an exception.
|
Assuming the tests pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a segfault for queries like
where the filters cover all the projected columns.