Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix window test and sleep longer on asof test #1204

Merged
merged 1 commit into from
Sep 1, 2023
Merged

fix window test and sleep longer on asof test #1204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions python/python/tests/test_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,17 +157,19 @@ def test_asof_checkout(tmp_path: Path):

lance.write_dataset(table, base_dir)
assert len(lance.dataset(base_dir).versions()) == 1
time.sleep(0.01)
time.sleep(0.1)
ts_1 = datetime.now()
time.sleep(0.01)
time.sleep(0.1)

lance.write_dataset(table, base_dir, mode="append")
assert len(lance.dataset(base_dir).versions()) == 2
time.sleep(0.1)
ts_2 = datetime.now()
time.sleep(0.01)
time.sleep(0.1)

lance.write_dataset(table, base_dir, mode="append")
assert len(lance.dataset(base_dir).versions()) == 3
time.sleep(0.1)
ts_3 = datetime.now()

# check that only the first batch is present
Expand Down
1 change: 1 addition & 0 deletions rust/src/io/commit/external_manifest.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,7 @@ mod test {
assert_eq!(ds.count_rows().await.unwrap(), 100);
}

#[cfg(not(windows))]
#[tokio::test]
async fn test_concurrent_commits_are_okay() {
let sleepy_store = SleepyExternalManifestStore::new();
Expand Down