refactor: move main macro benchmarks to python #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjones127
force-pushed
the
wjones127/python-benchmarks
branch
from
9dff2ea to
d59a1f3
Compare
wjones127
requested review from
eddyxu,
changhiskhan,
westonpace and
chebbyChefNEQ
eddyxu
approved these changes
Sep 7, 2023
| import pyarrow.compute as pc | ||
| import pytest | ||
|
|
||
| N_DIMS = 128 |
There was a problem hiding this comment.
Let's make this 768 or 1536 more realistic these days.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1218
This makes it easier to write, run, and profile benchmarks. Writing them in Python makes them faster to compile and not require recompilation if we only modify the benchmark itself.
We cache the expensive fixtures (like an indexed table) so that we can quickly run the benchmarks.