Move Expression based schema project to Schema class #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changhiskhan
approved these changes
Sep 2, 2022
| @@ -499,6 +499,19 @@ ::arrow::Result<std::shared_ptr<Schema>> Schema::Project( | |||
| return projection; | |||
| } | |||
|
|
|||
| ::arrow::Result<std::shared_ptr<Schema>> Schema::Project( | |||
| const ::arrow::compute::Expression& expr) const { | |||
There was a problem hiding this comment.
Does input need to be bound?
There was a problem hiding this comment.
It does not. This just read the schema and run projections.
Bound expr is only needed to feed into arrow::compute
| return nullptr; | ||
| } | ||
| std::vector<std::string> columns; | ||
| for (auto& ref : ::arrow::compute::FieldsInExpression(expr)) { |
There was a problem hiding this comment.
This does solve the nested field reference problem right?
There was a problem hiding this comment.
Oh, no. That's a separated issue.
cpp/src/lance/format/schema.h
Outdated
| @@ -14,6 +14,7 @@ | |||
|
|
|||
| #pragma once | |||
|
|
|||
| #include <arrow/compute/exec/expression.h> | |||
There was a problem hiding this comment.
Is this Arrow public API? Or is there a higher level header file for this?
There was a problem hiding this comment.
There is a arrow/compute/api.h should i use that one?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Schema::Project(const arrow::compute::Expression&)method to project the fields based on the fields references in the expression.