Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the condition of Scan advancing batch id #143

Merged
merged 1 commit into from
Sep 6, 2022
Merged

Fix the condition of Scan advancing batch id #143

merged 1 commit into from
Sep 6, 2022

Conversation

eddyxu
Copy link
Contributor

@eddyxu eddyxu commented Sep 5, 2022

No description provided.

@eddyxu eddyxu self-assigned this Sep 5, 2022
@eddyxu eddyxu added bug Something isn't working c++ C++ issues labels Sep 6, 2022
@eddyxu eddyxu requested a review from changhiskhan September 6, 2022 00:00
@eddyxu
Copy link
Contributor Author

eddyxu commented Sep 6, 2022

Without the fix, we have errors like

Index error: PlainEncoder(int32)::ToArray: out of range: start=20, length=4, page_length=20

@eddyxu eddyxu merged commit 57d7151 into main Sep 6, 2022
@eddyxu eddyxu deleted the lei/scan_next_batch branch September 6, 2022 00:44
eddyxu added a commit that referenced this pull request Sep 6, 2022
@eddyxu
Fix the condition of Scan advancing batch id (#143)
a26d034 
Fix batch read alignment caused failures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@changhiskhan changhiskhan changhiskhan approved these changes

Assignees

@eddyxu eddyxu

Labels
bug Something isn't working c++ C++ issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eddyxu @changhiskhan