Provide binary to profiling scans #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changhiskhan
reviewed
Sep 9, 2022
| auto scan_builder = lance::arrow::ScannerBuilder(dataset); | ||
| assert(scan_builder.Project(columns).ok()); | ||
| auto scanner = scan_builder.Finish().ValueOrDie(); | ||
| fmt::print("Dataset count: {}\n", scanner->CountRows().ValueOrDie()); |
There was a problem hiding this comment.
does CountRows actually execute the scan?
There was a problem hiding this comment.
Yes, it is a virtual function that calls ScanBatch by default. Also this is observed when SELECT count(1) FROM dataset is not optimized in duckdb.
We can change this code to use ScanBatch as well.
eddyxu
force-pushed
the
lei/profile_scan
branch
from
db23f09 to
628b251
Compare
changhiskhan
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a CLI executable to be used profiling scan performance