lance dataset that overrides Dataset.scanner and Dataset.head #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyxu
reviewed
Sep 12, 2022
python/lance/_lib.pyx
Outdated
| Dataset, | ||
| FileFormat, | ||
| FileWriteOptions, | ||
| CDataset, |
There was a problem hiding this comment.
fixed. not sure why pycharm is doing that
| scanner = self.scanner(limit=n, offset=offset) | ||
| return scanner.to_table() | ||
|
|
||
| def scanner(self, *args, **kwargs): |
There was a problem hiding this comment.
Are we going to deprecate lance.scanner()? Could be just remove it from this PR.
There was a problem hiding this comment.
makes sense. Can just do lance.dataset(...).scanner(...)
| @@ -36,6 +36,16 @@ def test_simple_round_trips(tmp_path: Path): | |||
| assert table == actual | |||
|
|
|||
|
|
|||
| def test_head(tmp_path: Path): | |||
There was a problem hiding this comment.
can we add a test to make sure duckdb works with this dataset
There was a problem hiding this comment.
there is an existing unit test that runs a duckdb query (how i discovered the problem originally)
eddyxu
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #141