Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert coco annotations from the list of structs to struct of lists #166

Merged
merged 2 commits into from
Sep 16, 2022
Merged

Convert coco annotations from the list of structs to struct of lists #166

merged 2 commits into from
Sep 16, 2022

Conversation

eddyxu
Copy link
Contributor

@eddyxu eddyxu commented Sep 15, 2022 •
edited
Loading

This is a short term mitigation for #95

@eddyxu eddyxu requested a review from changhiskhan September 15, 2022 22:42
@eddyxu eddyxu self-assigned this Sep 15, 2022
changhiskhan
changhiskhan reviewed Sep 15, 2022
View reviewed changes
Copy link
Contributor

@changhiskhan changhiskhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this make it easier to use Box2dArray?

@eddyxu
Copy link
Contributor Author

eddyxu commented Sep 15, 2022

does this make it easier to use Box2dArray?

Yes, it returns as an array<array<float>> for each example.

changhiskhan
changhiskhan approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@changhiskhan changhiskhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm going to put fixes/improvements in a separate PR

@changhiskhan changhiskhan merged commit 66d2c00 into main Sep 16, 2022
@changhiskhan changhiskhan deleted the lei/coco_nested branch September 16, 2022 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@changhiskhan changhiskhan changhiskhan approved these changes

Assignees

@eddyxu eddyxu

Labels
benchmark python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eddyxu @changhiskhan