Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: revert back to hashmap #1692

Merged
merged 3 commits into from
Dec 8, 2023
Merged

perf: revert back to hashmap #1692

merged 3 commits into from
Dec 8, 2023

Conversation

chebbyChefNEQ
Copy link
Contributor

revert back to hashmap for better performance for now.

Copy link
Contributor

@rok rok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wjones127
Copy link
Contributor

I've removed nohash entirely, since we only use it for rowids. Because of the number of collisions it's not a good choice in general.

I briefly tested xxh3 against the default hash, and it turns out the default hash is still 2x faster. So we should stick with the default hash for now.

Copy link
Contributor

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we end up changing it again let's make a type alias so it's easier in the future (but no need to do that today).

@wjones127 wjones127 merged commit 79b9233 into main Dec 8, 2023
17 checks passed
@wjones127 wjones127 deleted the rmeng/revert-intmap branch December 8, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants