Fix typo of calculating offsets for slicing index #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyxu
commented
Sep 27, 2022
| @@ -92,7 +92,7 @@ include_directories(src) | |||
| include_directories(${CMAKE_BINARY_DIR}/src) # for format.pb.{h/cc} | |||
|
|
|||
| function(add_lance_test test_name) | |||
| if (NOT CMAKE_BUILD_TYPE STREQUAL "Release") | |||
There was a problem hiding this comment.
Change CMakeFile to allow python side to build ReleaseWithDebugInfo mode , easier to see call stack.
changhiskhan
approved these changes
Sep 27, 2022
| @@ -32,7 +32,7 @@ ScanBatch ScanBatch::Slice(int64_t off, int64_t length) const { | |||
| auto sliced_batch = batch->Slice(off, length); | |||
| decltype(indices) sliced_indices; | |||
| if (indices) { | |||
| sliced_indices = std::dynamic_pointer_cast<::arrow::Int32Array>(indices->Slice(offset, length)); | |||
| sliced_indices = std::dynamic_pointer_cast<::arrow::Int32Array>(indices->Slice(off, length)); | |||
There was a problem hiding this comment.
not a blocker for this PR but should we go with the convention to add an _ suffix to member variables? Would that have made it clearer here?
There was a problem hiding this comment.
This ScanBatch struct was a POD struct in the beginning, so that the caller can directly use scan_batch.batch to access its fields. It becomes more complicated lately, we could change it to class and wrap the fields as private and with _ suffix later?
I am fine to work on it after the release.
There was a problem hiding this comment.
Added #207 to follow up with the remaining concerns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #203