-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Python] Exclude relocating packages in homebrew #210
Conversation
python/tools/delocate-wheel
Outdated
parser.add_argument("wheel", nargs="+") | ||
|
||
args = parser.parse_args() | ||
print(args) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove print?
python/tools/delocate-wheel
Outdated
out_dir = args.wheel_dir | ||
out_wheel = wheel | ||
if out_dir: | ||
if not os.path.exists(out_dir): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need this check if exist_ok=True?
args = parser.parse_args() | ||
print(args) | ||
for wheel in args.wheel: | ||
out_dir = args.wheel_dir |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if out_dir is None? Should this be required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed.
8970b09
to
39371fc
Compare
Verified it works after uninstall
After this PR, the size of wheel
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
w00t
Closes #198 and #196