Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix datagen test #234

Merged
merged 4 commits into from
Oct 13, 2022
Merged

Fix datagen test #234

merged 4 commits into from
Oct 13, 2022

Conversation

eddyxu
Copy link
Contributor

@eddyxu eddyxu commented Oct 13, 2022

Closes #232

@@ -4,7 +4,7 @@ on:
push:
branches:
- main
- gha
pull_request:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will remove this line after approval

Copy link
Contributor

@changhiskhan changhiskhan Oct 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future reference Feel free to force push to gha branch to test something out GHA related. That way we don't need to change anything manually

@eddyxu eddyxu marked this pull request as ready for review October 13, 2022 20:04
@eddyxu eddyxu requested a review from changhiskhan October 13, 2022 20:04
@eddyxu eddyxu self-assigned this Oct 13, 2022
@eddyxu eddyxu added the ci Github Action or Test issues label Oct 13, 2022
@eddyxu eddyxu merged commit 81bc5ca into main Oct 13, 2022
@eddyxu eddyxu deleted the lei/fix_datagen branch October 13, 2022 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Github Action or Test issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datagen test is flaky
2 participants