readability improvement for metadata class #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyxu
reviewed
Oct 31, 2022
| } | ||
| auto it = std::upper_bound(pb_.batch_offsets().begin(), pb_.batch_offsets().end(), row_index); | ||
| if (it == pb_.batch_offsets().end()) { | ||
| return ::arrow::Status::IndexError("Row index out of range {} of {}", row_index, len); | ||
| } | ||
| int32_t bound_idx = std::distance(pb_.batch_offsets().begin(), it); | ||
| int32_t bound_idx = std::distance(pb_.batch_offsets().begin(), it) - 1; |
There was a problem hiding this comment.
what if the it == batch_offset().begin() ? in such case bound_idx = -1?
There was a problem hiding this comment.
The first value of offsets is always 0, row_index is always not less than 0, so this case should not happen unless we change how offsets works.
https://github.com/eto-ai/lance/blob/861230d0d8186312e18f206fb8262eb919828549/cpp/src/lance/format/metadata.cc#L59
There was a problem hiding this comment.
ok, got it. It seems line #83 assert is always true as well? lets remove it?
eddyxu
reviewed
Oct 31, 2022
| } | ||
| auto it = std::upper_bound(pb_.batch_offsets().begin(), pb_.batch_offsets().end(), row_index); | ||
| if (it == pb_.batch_offsets().end()) { | ||
| return ::arrow::Status::IndexError("Row index out of range {} of {}", row_index, len); | ||
| } | ||
| int32_t bound_idx = std::distance(pb_.batch_offsets().begin(), it); | ||
| int32_t bound_idx = std::distance(pb_.batch_offsets().begin(), it) - 1; |
There was a problem hiding this comment.
ok, got it. It seems line #83 assert is always true as well? lets remove it?
cpp/src/lance/format/metadata.cc
Outdated
| @@ -68,16 +68,19 @@ int32_t Metadata::GetBatchLength(int32_t batch_id) const { | |||
|
|
|||
| ::arrow::Result<std::tuple<int32_t, int32_t>> Metadata::LocateBatch(int32_t row_index) const { | |||
| int64_t len = length(); | |||
| if (len == 0) { | |||
| return ::arrow::Status::IndexError(fmt::format("The offsets table is empty")); | |||
There was a problem hiding this comment.
don't need fmt::format here
eddyxu
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.