[Python] Fetch dataset versions. #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changhiskhan
approved these changes
Nov 2, 2022
| @@ -158,6 +161,17 @@ cdef extern from "lance/arrow/dataset.h" namespace "lance::arrow" nogil: | |||
| optional[uint64_t] version, | |||
| ) | |||
|
|
|||
| CDatasetVersion version() const; | |||
There was a problem hiding this comment.
How come this is not wrapped in CResult?
There was a problem hiding this comment.
Right, so this is fetching the "current version", which is converting from already loaded Manifest. There is no I/O involved , so no error case in this code path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide
version(),versions(),latest_version()methods to Python