Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix image_id alignment in coco datagen #289

Merged
merged 2 commits into from
Nov 4, 2022

Conversation

changhiskhan
Copy link
Contributor

No description provided.

@changhiskhan changhiskhan requested a review from eddyxu November 4, 2022 02:39
anno_df = (
pd.DataFrame(
{
"image_id": df.image_id,
"image_id": annotations_df.image_id,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this the fix? while the rest are cleanups?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, one line fix 🤦

Copy link
Contributor

@eddyxu eddyxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Pending CI

@changhiskhan
Copy link
Contributor Author

CI should be fixed after #293

@changhiskhan changhiskhan merged commit a5736e2 into main Nov 4, 2022
@changhiskhan changhiskhan deleted the changhiskhan/fix-coco-datagen branch November 4, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants