Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support FTS on multiple fields #3025

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

BubbleCal
Copy link
Contributor

this introduces multiple fields FTS in best_fields, it finds documents that match any field, and uses the score from the best field.

@github-actions github-actions bot added the enhancement New feature or request label Oct 20, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2024

Codecov Report

Attention: Patch coverage is 96.42857% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.42%. Comparing base (038f239) to head (6fc3a31).

Files with missing lines Patch % Lines
rust/lance/src/dataset/scanner.rs 84.21% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3025      +/-   ##
==========================================
+ Coverage   78.40%   78.42%   +0.01%     
==========================================
  Files         239      239              
  Lines       76861    76917      +56     
  Branches    76861    76917      +56     
==========================================
+ Hits        60264    60322      +58     
+ Misses      13497    13495       -2     
  Partials     3100     3100              
Flag Coverage Δ
unittests 78.42% <96.42%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: BubbleCal <[email protected]>
@BubbleCal BubbleCal marked this pull request as ready for review October 20, 2024 10:41
@BubbleCal BubbleCal merged commit 7413344 into lancedb:main Oct 22, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants