-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expose compression-level configuration for general compression #3034
feat: expose compression-level configuration for general compression #3034
Conversation
I check zstd/lz4/snappy [1][2][3], and all of them have the concept of compression level, and all of them use an integer to express such compression level but they use different integers as their default values (zstd uses [1] zstd compression level, http://facebook.github.io/zstd/zstd_manual.html#Chapter1 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3034 +/- ##
==========================================
+ Coverage 78.24% 78.38% +0.14%
==========================================
Files 240 240
Lines 77284 78475 +1191
Branches 77284 78475 +1191
==========================================
+ Hits 60470 61515 +1045
- Misses 13696 13845 +149
+ Partials 3118 3115 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable.
@niyue Could you fix the clippy lints from the Java CI? These do originate from your rust code. |
275177d
to
2a43118
Compare
Sure. I updated the code to fix the clippy lint issue and two more unit tests. Please check them out. Thanks. |
some lint errors, should be fixable with |
2a43118
to
0346801
Compare
Thanks, fixed. |
This PR aims to address #3033, and expose the compression level for general compression.