feat: add max length statistics to VariableWidth Datablock #3082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3082 +/- ##
==========================================
+ Coverage 77.31% 77.33% +0.01%
==========================================
Files 240 240
Lines 79322 79396 +74
Branches 79322 79396 +74
==========================================
+ Hits 61326 61399 +73
- Misses 14821 14824 +3
+ Partials 3175 3173 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
westonpace
approved these changes
Nov 5, 2024
Comment on lines
1161
to
1164
| "Expected Stat::MaxLength to be {:?} for data block generated from array: {:?}", | ||
| expected_max_length, | ||
| string_array, | ||
| ); |
There was a problem hiding this comment.
Super minor nit but I find this to be a bit redundant. You are calling assert_eq and therefore it should already be clear what was expected. I think custom error messages are only really requires when they add surprising or unexpected context.
There was a problem hiding this comment.
thanks, fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
max length statistics can be used to for encoding selection of Variable-Width-Datablock(string, binary, etc.)