Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: implement fast path for union many row id tree map #3087

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

chebbyChefNEQ
Copy link
Contributor

@chebbyChefNEQ chebbyChefNEQ commented Nov 5, 2024

Use roaring::MultiOp for faster union of bitmaps.

TODO:

  • add a benchmark to figure out how much we are saving from this
  • add a row id tree map benchmark to compare union_all and regular loop

}
Self::Partial(bitmap) => Some(bitmap),
})
.union(),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is essentially betting that full is rare. We might want more comprehensive benchmarks to tune the behavior here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah Full is mostly to represent the deletion prefilter. For bitmap I think your right it should be rare.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 92.68293% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.32%. Comparing base (ceaf49c) to head (65502fe).

Files with missing lines Patch % Lines
rust/lance-core/src/utils/mask.rs 91.42% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3087      +/-   ##
==========================================
+ Coverage   77.31%   77.32%   +0.01%     
==========================================
  Files         240      240              
  Lines       79322    79358      +36     
  Branches    79322    79358      +36     
==========================================
+ Hits        61326    61365      +39     
- Misses      14821    14825       +4     
+ Partials     3175     3168       -7     
Flag Coverage Δ
unittests 77.32% <92.68%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chebbyChefNEQ chebbyChefNEQ merged commit b7663fb into main Nov 5, 2024
32 of 33 checks passed
@chebbyChefNEQ chebbyChefNEQ deleted the rmeng/multiops branch November 5, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants