feat: add compaction support to balanced datasets #3088
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows compaction to succeed on the default storage.
Running compaction on the sibling storage can be added in a future PR.
In addition, this PR adds quite a few more test cases to make sure that a balanced dataset either performs as expected or gives a good "not yet supported" error message.
In addition, this PR reworks the dataset-offset based take (e.g.
LanceDataset::take
) to reuse the id-based & address-based take paths (e.g.TakeBuilder
)It also fixes a bug in the
TakeBuilder
path where duplicate IDs were not being handled.These latter changes are not strictly needed but are preparing for an eventual revamp of the take operation to address #2977