Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fp16 GPU training #3105

Merged
merged 1 commit into from
Nov 8, 2024
Merged

fix: fp16 GPU training #3105

merged 1 commit into from
Nov 8, 2024

Conversation

chebbyChefNEQ
Copy link
Contributor

@chebbyChefNEQ chebbyChefNEQ commented Nov 8, 2024

  • cast ivf centroids to the same type as vectors before inference
  • cast codebook to the same type as ivf centroid before passing to rust
  • fix typing syntax

@github-actions github-actions bot added bug Something isn't working python labels Nov 8, 2024
Copy link
Contributor

@eddyxu eddyxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you just add one small test

@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.05%. Comparing base (8155c25) to head (f1b6048).

Files with missing lines Patch % Lines
rust/lance-index/src/vector/ivf/shuffler.rs 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3105      +/-   ##
==========================================
+ Coverage   77.03%   77.05%   +0.02%     
==========================================
  Files         240      240              
  Lines       80410    80412       +2     
  Branches    80410    80412       +2     
==========================================
+ Hits        61943    61965      +22     
+ Misses      15265    15263       -2     
+ Partials     3202     3184      -18     
Flag Coverage Δ
unittests 77.05% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chebbyChefNEQ chebbyChefNEQ merged commit 822cf82 into main Nov 8, 2024
29 checks passed
@chebbyChefNEQ chebbyChefNEQ deleted the rmeng/gpu-f16 branch November 8, 2024 04:10
@eddyxu
Copy link
Contributor

eddyxu commented Nov 8, 2024

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants