Notebook for new blog post on versioning #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyxu
reviewed
Nov 15, 2022
| @@ -0,0 +1,8 @@ | |||
| // | |||
There was a problem hiding this comment.
No function declartion in this file?
Also, could you change header, and use #pragma once instead of macro to protect header file?
There was a problem hiding this comment.
shoot, that's actually the next blog post. let me remove this
| namespace lance::duckdb { | ||
|
|
||
| template <typename T> | ||
| void L2Distance(::duckdb::DataChunk &args, |
There was a problem hiding this comment.
what is the difference of this to https://github.com/eto-ai/lance/blob/main/integration/duckdb/src/lance/duckdb/vector_functions.cc#L25
changhiskhan
force-pushed
the
changhiskhan/versioning-blog
branch
from
22acab7 to
be2fac9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
includes some minor refactoring to dataset conversion API