Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: lance-encoding test utility now properly aligns buffers #3116

Merged

Conversation

westonpace
Copy link
Contributor

@westonpace westonpace commented Nov 11, 2024

We align buffers in the file writer but we were not doing the same thing in the test utility. This forced encodings to do extra copies. We remove one such copy in this PR.

Closes #3115

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 77.13%. Comparing base (c237bcb) to head (b5117b9).

Files with missing lines Patch % Lines
rust/lance-encoding/src/encoder.rs 16.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3116      +/-   ##
==========================================
+ Coverage   77.11%   77.13%   +0.01%     
==========================================
  Files         240      240              
  Lines       80643    80652       +9     
  Branches    80643    80652       +9     
==========================================
+ Hits        62190    62213      +23     
+ Misses      15275    15274       -1     
+ Partials     3178     3165      -13     
Flag Coverage Δ
unittests 77.13% <66.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@broccoliSpicy broccoliSpicy merged commit 4ab270b into lancedb:main Nov 11, 2024
28 of 29 checks passed
@broccoliSpicy
Copy link
Contributor

some benchmark results related to this PR:
before eliminating copy:
Screenshot 2024-11-11 at 2 55 14 PM

after eliminating copy:
Screenshot 2024-11-11 at 2 53 20 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants