Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add commit_batch API #3142

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Conversation

wjones127
Copy link
Contributor

@wjones127 wjones127 commented Nov 19, 2024

This allows users to commit a sequence of transactions as one new version. Right now, this only supports Append transactions, which are trivial to merge.

Closes #3097

@github-actions github-actions bot added enhancement New feature or request python java labels Nov 19, 2024
@wjones127 wjones127 changed the title feat: add batch_commit API feat: add commit_batch API Nov 21, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 87.30159% with 16 lines in your changes missing coverage. Please review.

Project coverage is 77.91%. Comparing base (8069936) to head (76e974d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
rust/lance/src/dataset/write/commit.rs 87.30% 6 Missing and 10 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3142      +/-   ##
==========================================
+ Coverage   77.89%   77.91%   +0.02%     
==========================================
  Files         242      242              
  Lines       82183    82296     +113     
  Branches    82183    82296     +113     
==========================================
+ Hits        64020    64125     +105     
+ Misses      14973    14965       -8     
- Partials     3190     3206      +16     
Flag Coverage Δ
unittests 77.91% <87.30%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@wjones127 wjones127 marked this pull request as ready for review November 21, 2024 18:31
@wjones127 wjones127 merged commit 0cda59a into lancedb:main Nov 21, 2024
26 checks passed
@wjones127 wjones127 deleted the feat/batch-commit branch November 21, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request java python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add bulk commit API
3 participants